Skip to content

Comments

West Midlands | ITP - January 2026 | Jonathan Boahene | Sprint 2 | Form Control#1193

Open
Abayie wants to merge 4 commits intoCodeYourFuture:mainfrom
Abayie:form-control
Open

West Midlands | ITP - January 2026 | Jonathan Boahene | Sprint 2 | Form Control#1193
Abayie wants to merge 4 commits intoCodeYourFuture:mainfrom
Abayie:form-control

Conversation

@Abayie
Copy link

@Abayie Abayie commented Feb 21, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Updated the HTML form to include customer information fields, color selection, size selection, and delivery date. Changed the footer to reflect the author's name.

Form control assignment

Questions

No questions

Updated the HTML form to include customer information fields, color selection, size selection, and delivery date. Changed the footer to reflect the author's name.
@netlify
Copy link

netlify bot commented Feb 21, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit f0ab22e
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/699ae590510cb3000874b318
😎 Deploy Preview https://deploy-preview-1193--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@Abayie Abayie added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 21, 2026
@wilsonadenuga wilsonadenuga added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 21, 2026
@Abayie Abayie added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 21, 2026
@cjyuan cjyuan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 21, 2026
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Lighthouse Accessibility score not yet 100.

  • According to https://validator.w3.org/, there are several warnings in your HTML code. Can you address these warnings?

type="text"
id="name"
name="user-name"
pattern="[A-Za-z\s]{2,}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know what this regular expression mean?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I do know what regular expression mean
regular expression is a rule that describes what kind of text you’re looking for

Copy link
Contributor

@cjyuan cjyuan Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, this particular one [A-Za-z\s]{2,}.

It does not quite match the description of the title attribute value:
Please enter your full name with at least two letters.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the question, and i don't see the challenge you're trying to address here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What names does the pattern [A-Za-z\s]{2,} match?

The value of the title attribute is "Please enter your full name with at least two letters.". Does the "letters" include space characters?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know what you mean now, I mean in the case there are two ways to fix it, either change the regex to enforce full name as in the description or change the description from full name to just name
I will do the later as full name isn't necessarily required but want to enforce characters to the minimum

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To only enforce minimum number of characters in the input, there is a HTML attribute for that purpose.

Regex is more suitable if we need to ensure the input matches certain pattern. You can explore regex later.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 21, 2026
fix accessibilty score and w3c validator warnings
@Abayie
Copy link
Author

Abayie commented Feb 21, 2026

All comments addressed and accessibilty score is 100% now

@Abayie Abayie added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 21, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 21, 2026

There are still warnings in your HTML code -- it means some tags are not used properly. Can you fix them?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 21, 2026
@Abayie
Copy link
Author

Abayie commented Feb 21, 2026

Fixed the warnings

@Abayie Abayie added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 21, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 21, 2026

Can you also address #1193 (comment) ?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 21, 2026
@Abayie
Copy link
Author

Abayie commented Feb 22, 2026

addressed comment #1193

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 22, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 22, 2026

Changes are good. Well done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants